#2901 Add support for overflow to POCOs #2918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first shot at adding support for overflow to POCOs. It should not introduce major breaking changes.
Remarks
this[]
operator for setting values, as we already had a getter for it hidden behindIReadOnlyDictionary
. This meant that an existingthis[]
operator on theParameter
resource had to be removed as it conflicted with this operator inBase
. Later I implemented this operator explicitly, so the problem does not exist anymore, but just for future flexibility I am removing this minor feature. This is a breaking change.ICollection<T>
to detect whether an element repeated or not. I changed the method in ReflectionHelper to detectIList<>
instead. This is a breaking change.Related issues
Fixes #2901.