Generalize handling of Base/Conformance properties that changed type #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-reflect-shared-properties # Conflicts: # src/Hl7.Fhir.Base/Model/Generated/Element.cs # src/Hl7.Fhir.Base/Model/Generated/Extension.cs
Kasdejong
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review the generated code: there are no relevant code changes in the satellites, only in Base and Conformance, so you would only have to look through the generated files in those projects.
Otherwise, I only had to fix some unit tests lightly, esp. for Attachment.size, since this is no longer always a long.
Fixes #2967.
Breaking changes
ElementDefinition.constraint.requirements,ElementDefinition.binding.description,ElementDefinition.mapping.commentandCapabilityStatement.implementation.descriptionhave changed fromMarkdowntoPrimitiveType. Set this property toMarkdownto get the original behaviour, but you can now use the correct type depending on the version of FHIR you are writing against.Attachment.sizehas changed fromInteger64toPrimitiveType. Set this property toInteger64to get the original behaviour, but you should now assign the correct type (i.e.UnsignedIntegerbefore R5) depending on the version of FHIR you are writing against.Bundle.Link.relationhas changed fromFhirStringtoPrimitiveType. Set this property toInteger64to get the original behaviour, but you can now use the correct type depending on the version of FHIR you are writing against.Meta.profilehas changed fromCanonicaltoCode. Set this property toInteger64to get the original behaviour, but you can now use the correct type depending on the version of FHIR you are writing against.