Support for manipulating request and response body #496
Conversation
* Added callbacks that allows manipulation of the request and response stream * See issue #478 for more information
|
Anyway, maybe we can piggyback on the new pipeline capabilities in the HttpClient. I am still getting updated on that new class, so I don't know yet! |
|
Agree, didn't look into it in detail earlier, but I see now that it's the same interface that's used on the server side and it should therefore work quite similar. |
| Stream respStream = response.GetResponseStream(); | ||
| respStream = streamProcessor(respStream, response.Headers); | ||
|
|
||
| body = HttpUtil.ReadAllFromStream(respStream); |
There was a problem hiding this comment.
I think there's a potential risk with the new code: you can nest the streams (good design), but the streams, except for the "outer" one, will never get closed anymore. This was done with the "using" statement in the original code, but this is gone. So, we have a potential resource leak. At least we need to make sure that all more outer streams close their inner stream, except for the most inner one (which is the original stream coming from the request).
In fact, because we "+=" to the delegate, the order of execution is undetermined (see for example here: https://stackoverflow.com/questions/1645478/order-of-event-handler-execution), so there is no guarantee that they are called in the order they are supplied.
I think it is better if we create a List<Func<...>> and iterate over it, passing the returned value onto the next. Since we can then also capture the return values, we can in fact make sure they get disposed as well.
|
@kennethmyhra -- oops, I never submitted my review on this PR....Is this PR still of interest to you? (the new client written in #535 will actually fix this is a more elegant way, because of the new .NET Core webclient used). |
|
@ewoutkramer I am happy with the solution that the .NET Core WebClient gives us in PR #507. |
stream