Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow editing scheduled changes #3227

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes issue introduced in #3118 which prevents scheduled changes from being edited / deleted.

How did you test this code?

Manually tested that:

  • a change scheduled in the future can be edited / deleted
  • a published change request with a live from in the past still cannot be edited / deleted

@matthewelwell matthewelwell requested review from a team and novakzaballa and removed request for a team January 2, 2024 17:11
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 5:13pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 5:13pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 5:13pm

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Uffizzi Preview deployment-43708 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 90ee8c7 Jan 18, 2024
19 checks passed
@matthewelwell matthewelwell deleted the fix/allow-editing-scheduled-changes branch January 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants