Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version diff overflow #4313

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: version diff overflow #4313

merged 1 commit into from
Jul 9, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes wrapping and overflow when viewing a large remote config change

image

How did you test this code?

Viewed https://app.flagsmith.com/project/12/environment/Ueo6zkrS8kt4LzuaJF9NFJ/history/08250695-d765-413c-8753-d6eb56b73ce2/

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 9, 2024 09:59
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 9, 2024 09:59
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 10:00am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 10:00am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 9, 2024 10:00am

@kyle-ssg kyle-ssg changed the title Fix version diff overflow fix: version diff overflow Jul 9, 2024
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4313 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4313 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4313 Finished ✅ Skipped

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4313 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4313 Finished ✅ Results ✅

@kyle-ssg kyle-ssg requested a review from matthewelwell July 9, 2024 10:00
@kyle-ssg kyle-ssg linked an issue Jul 9, 2024 that may be closed by this pull request
Version detail page styling issue for large JSON values #4260
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Uffizzi Preview deployment-53984 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 2525636 Jul 9, 2024
28 checks passed
@kyle-ssg kyle-ssg deleted the style/fix-version-diff-overflow branch July 9, 2024 17:05
@flagsmithdev flagsmithdev mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version detail page styling issue for large JSON values
2 participants
@kyle-ssg @novakzaballa