Check that package.xml exists before trying to read it. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages/stacks may not have a package.xml, but ros will report them as existing packages
|
Thank you for spotting this and fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very old packages/stacks may not have a package.xml, but ROS will report them as existing packages. This will cause flexbe_app to fail silently and any packages left to be parsed will be skipped.
This patch addresses the issue by checking that package.xml exists before reading this.
Just a note, I don't really know anything about javascript/Node.js so there may be a much better way of handling this, but it worked for my use case.