using a ThreadPoolExecutor to match socket pool #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyp
requested review from
rockhunters08,
KimberlyGrommes,
stevefranks and
jsgoldstein
zacharyp
changed the title
stevefranks
reviewed
May 20, 2023
pybase/region/client.py
Outdated
| @@ -142,7 +142,6 @@ def _send_request(self, rq, lock_timeout=10): | |||
| to_send = pack(">IB", total_length - 4, len(serialized_header)) | |||
| to_send += serialized_header + rpc_length_bytes + serialized_rpc | |||
|
|
|||
| pool_id = my_id % self.pool_size | |||
| try: | |||
| # todo: quick hack to patch a deadlock happening here. Needs revisiting. | |||
| with acquire_timeout(self.write_lock_pool[pool_id], lock_timeout) as acquired: | |||
There was a problem hiding this comment.
There's still a reference to the write_lock_pool here
stevefranks
reviewed
May 20, 2023
pybase/region/client.py
Outdated
| sp = thread_name.split("_") # i.e. splitting "ThreadPoolExecutor-1_0" | ||
| pool_id = int(sp[1]) # thread number is now responsible for only using its matching socket | ||
|
|
||
| client.sock_pool[pool_id].send(to_send) |
There was a problem hiding this comment.
Should we move the send into the try below to be able use the same exception handling?
stevefranks
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making multiple locks between sending and receiving insanity... why not just have a ThreadPoolExecutor with a number of threads equal to the socket pool size. Then users of the Client can simply submit work, and open thread in the ThreadPool will simply do the work. Each thread in a ThreadPoolExecutor has a unique number (say
ThreadPoolExecutor-1_0where the last number is the thread number. Simply use that number to decide which socket to use, and voilà, no more contention for a socket.I'll test this Monday.