Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusts menu layout for different device types #14

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Adjusts menu layout for different device types #14

merged 3 commits into from
Jan 31, 2020

Conversation

tonytlwu
Copy link
Contributor

@tonytlwu tonytlwu mentioned this pull request Jan 30, 2020
Merged
tonytlwu
tonytlwu commented Jan 30, 2020
View reviewed changes
js/menu.js Outdated Show resolved Hide resolved
squallstar
squallstar approved these changes Jan 30, 2020
View reviewed changes
Copy link

@squallstar squallstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but asking @hcarneiro to review this as well

@tonytlwu tonytlwu requested a review from hcarneiro January 30, 2020 10:17
@tonytlwu tonytlwu merged commit 077506d into master Jan 31, 2020
@tonytlwu tonytlwu deleted the chore/menu-layout branch January 31, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squallstar squallstar squallstar approved these changes

@hcarneiro hcarneiro hcarneiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonytlwu @squallstar @hcarneiro