Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Added key accessibility for most LFD features #416

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

YaroslavOvdii
Copy link
Contributor

@sofiiakvasnevska

Issue

https://github.com/Fliplet/fliplet-studio/issues/6423

Description

Added key accessibility for most LFD features

Screenshots/screencasts

https://share.getcloudapp.com/KourrkeE

Backward compatibility

This change is fully backward compatible.

Reviewers

@upplabs-alex-levchenko

Notes

Created new PR for this PR to avoid conflicts with others PRs.

tonytlwu
tonytlwu previously approved these changes Aug 19, 2020
@tonytlwu
Copy link
Contributor

Conflicts to resolve

@tonytlwu
Copy link
Contributor

https://share.getcloudapp.com/KourrkeE

  1. The first 6 seconds of the video tabs from Menu > Search bar > Bookmarks > Filters. The outline highlights all look slightly different. They need to look consistent in its opacity, fade, thickness etc.
  2. At around 0:08, when the filters are activated, the focus should stay on the Filter toggle so that users can press ENTER repeatedly to toggle the filters on and off.
  3. At 0:34, the disabled date selectors should not be TAB-able because they don't do anything.
  4. At 1:17, it looks like you had to click on the overlay a few times. Why was that? Is it because you pressed TAB a few times and nothing happened? Is it because it was cycling through the elements behind the overlay?
  5. At 3:11, it looks like it took you a while to focus on the comment field. Did you have to press TAB multiple times? The overlay opening should allow users to start TAB-ing through the overlay UI elements right away

@@ -221,6 +221,8 @@ DynamicList.prototype.attachObservers = function() {
return;
}

_this.$container.find('.news-feed-list-wrapper').hide();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the main the list being toggled on and off. Why?

And when the list is shown again, does it restore its scroll position? e.g. if the list was previously scrolled to 30% down the list, does it restore to the same point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants