-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Added key accessibility for most LFD features #416
base: master
Are you sure you want to change the base?
Conversation
Conflicts to resolve |
https://share.getcloudapp.com/KourrkeE
|
@@ -221,6 +221,8 @@ DynamicList.prototype.attachObservers = function() { | |||
return; | |||
} | |||
|
|||
_this.$container.find('.news-feed-list-wrapper').hide(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the main the list being toggled on and off. Why?
And when the list is shown again, does it restore its scroll position? e.g. if the list was previously scrolled to 30% down the list, does it restore to the same point?
@sofiiakvasnevska
Issue
https://github.com/Fliplet/fliplet-studio/issues/6423
Description
Added key accessibility for most LFD features
Screenshots/screencasts
https://share.getcloudapp.com/KourrkeE
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko
Notes
Created new PR for this PR to avoid conflicts with others PRs.