OD-357 [Fix] Users with previosly setup filters will see correct selected filter type and value #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added files view for the LFD detailed view
Revert "added files view for the LFD detailed view"
I suggest you find the point in the commit history before the last set of changes were applied so you can set up widgets in Studio that have the old configuration settings and then upload your fix to confirm it works. We can't have bug fixes that you haven't verified works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
Issue
https://weboo.atlassian.net/browse/OD-357
Description
That seems to be when old users receive updates they don't have an
item.fieldValueoritem.valueTypevariables in the filter option.That is why we were seeing empty
Value typeandValuefields.With the current fix, we will have a fullback in cases when users have an old configuration of the filter options.
Screenshots/screencasts
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko
Notes
Unfortunately, I wasn't able to replicate this issue on staging because I don't have, an old configurated LFD with my package to see changes but I'm sure this fix will work on staging.