Created new Picture Choice field #484
Conversation
.idea/.gitignore
Outdated
There was a problem hiding this comment.
If you find that your IDE setup is adding new files like this .idea folder, you should update the .gitignore in the repo root to exclude the files.
css/form.css
Outdated
| @@ -1,5 +1,6 @@ | |||
| .fl-form { | |||
| position: relative; | |||
| padding: 15px; | |||
There was a problem hiding this comment.
It's very unlikely that in order to add a new picture choice field, the entire form container needs a 15px padding around. This will introduce a breaking change to all the Form instances from our users.
js/libs/builder.js
Outdated
| @@ -77,26 +87,30 @@ Vue.directive('sortable', { | |||
| }); | |||
|
|
|||
| function generateFormDefaults(data) { | |||
| return _.assign({ | |||
There was a problem hiding this comment.
I'm able to open this file and save it without the linter or formatter making any changes (ref)
This suggests either you made this change manually or your editor is set up incorrectly.
js/libs/builder.js
Outdated
| @@ -182,7 +204,9 @@ Fliplet().then(function() { | |||
| } | |||
|
|
|||
| if (this.newColumns.length > 1) { | |||
| return this.newColumns.length + ' columns missing in the data source.'; | |||
| return ( | |||
There was a problem hiding this comment.
Way too many unnecessary changes in this PR, see my comment above on IDE setup.
js/libs/form.js
Outdated
| @@ -611,6 +611,10 @@ Fliplet().then(function () { | |||
| } | |||
| } | |||
|
|
|||
| if (type === 'flPictureChoice' && value ==='') { | |||
| value = {} | |||
There was a problem hiding this comment.
Semi-colon missing. Please check your IDE setup.
…er into @armine-flipet/FEAT-create-new-picture-choice-field
No description provided.