Release/v1.3.1 #33
Release/v1.3.1 #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
- Coverage 50.65% 50.46% -0.2%
=========================================
Files 29 29
Lines 1297 1302 +5
Branches 345 347 +2
=========================================
Hits 657 657
- Misses 640 645 +5
Continue to review full report at Codecov.
|
| if (!this.isRunningAction) { | ||
| this.onStartAction(); | ||
| if (options.mxObject) { | ||
| // handleOnClick(options.options, options.mxObject, options.mxForm); |
| mx.ui.hideProgress(this.showProgress); | ||
| } | ||
|
|
||
| } |
| .then(newMxObject => { | ||
| handleOnClick(options.options, newMxObject, options.mxForm) | ||
| .then(this.onStopActionbound) | ||
| .catch((error) => { |
There was a problem hiding this comment.
no need for parentheses around (error)
| } | ||
| } , 120); | ||
| } | ||
| private onStopAction() { |
There was a problem hiding this comment.
empty line before function declaration
There was a problem hiding this comment.
Thanks for catching it. (uuh, I have references of usage on top of every function, they mislead, however my linters should do their job - will fix them)
| private instanceID = getInstanceID(this.props.friendlyId, store, "bar"); | ||
| private scatterData = this.getData(this.props); |
There was a problem hiding this comment.
When new series are added in the WM will they all have new data?
src/utils/data.ts
Outdated
| const context = new mendix.lib.MxContext(); | ||
|
|
||
| if (!mxObject || options.onClickEvent === "doNothing") { | ||
| return; | ||
| resolve(); |
Includes fix to: