solves issue #29 + refactoring #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The camera can now be moved relative to the scene by dragging with the right mouse button, both in orbital as well as WASD mode. In my opinion using the right mouse button instead of the middle one results in a better user experience. When dragging with the middle mouse button it can easily happen that also the wheel moves a little bit. Please try the feature out, do a code review and let me know about improvement ideas. I thought of making the dragging smoother by adding some momentum and ignoring negligible changes in the mouse position. But I suggest we leave that for another issue.
…tyle into separate file and exclude it from black formatting in pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera can now be moved relative to the scene by dragging with the right mouse button, both in orbital as well as WASD mode. In my opinion using the right mouse button instead of the middle one results in a better user experience. When dragging with the middle mouse button it can easily happen that also the wheel moves a little bit.
Please try the feature out, do a code review and let me know about improvement ideas. I thought of making the dragging smoother by adding some momentum and ignoring negligible changes in the mouse position. But I suggest we leave that for another issue.