Removed deprecated default props declarations on UI components

FlorianLeChat · Jan 1, 2025 · 4af9fd5 · 4af9fd5
1 parent 566baaf
commit 4af9fd5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 19 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -13,6 +13,7 @@
 			"files": ["**/components/ui/*.tsx", "**/utilities/env.ts"],
 			"rules": {
 				"react/prop-types": "off",
+				"react/require-default-props": "off",
 				"@typescript-eslint/no-empty-object-type": "off"
 			}
 		}

diff --git a/app/[locale]/components/ui/button.tsx b/app/[locale]/components/ui/button.tsx
@@ -57,10 +57,6 @@ const Button = forwardRef<HTMLButtonElement, ButtonProps>(
 	}
 );
 
-Button.defaultProps = {
-	asChild: false
-};
-
 Button.displayName = "Button";
 
 export { Button, buttonVariants };
diff --git a/app/[locale]/components/ui/dropdown-menu.tsx b/app/[locale]/components/ui/dropdown-menu.tsx
@@ -37,10 +37,6 @@ const DropdownMenuSubTrigger = forwardRef<
 	</DropdownMenuPrimitive.SubTrigger>
 ) );
 
-DropdownMenuSubTrigger.defaultProps = {
-	inset: false
-};
-
 DropdownMenuSubTrigger.displayName =
 	DropdownMenuPrimitive.SubTrigger.displayName;
 
@@ -97,10 +93,6 @@ const DropdownMenuItem = forwardRef<
 	/>
 ) );
 
-DropdownMenuItem.defaultProps = {
-	inset: false
-};
-
 DropdownMenuItem.displayName = DropdownMenuPrimitive.Item.displayName;
 
 const DropdownMenuCheckboxItem = forwardRef<
@@ -168,10 +160,6 @@ const DropdownMenuLabel = forwardRef<
 	/>
 ) );
 
-DropdownMenuLabel.defaultProps = {
-	inset: false
-};
-
 DropdownMenuLabel.displayName = DropdownMenuPrimitive.Label.displayName;
 
 const DropdownMenuSeparator = forwardRef<
@@ -190,7 +178,7 @@ DropdownMenuSeparator.displayName = DropdownMenuPrimitive.Separator.displayName;
 function DropdownMenuShortcut( {
 	className,
 	...props
-}: HTMLAttributes<HTMLSpanElement> )
+}: Readonly<HTMLAttributes<HTMLSpanElement>> )
 {
 	return (
 		<span

diff --git a/app/[locale]/components/ui/progress.tsx b/app/[locale]/components/ui/progress.tsx
@@ -22,7 +22,7 @@ const Progress = forwardRef<
 	>
 		<ProgressPrimitive.Indicator
 			className="size-full flex-1 bg-primary transition-all"
-			style={{ transform: `translateX(-${ 100 - ( value || 0 ) }%)` }}
+			style={{ transform: `translateX(-${ 100 - ( value ?? 0 ) }%)` }}
 		/>
 	</ProgressPrimitive.Root>
 ) );

diff --git a/config/routes.tsx b/config/routes.tsx
@@ -1,11 +1,12 @@
 //
 // Déclaration des routes vers les différentes pages des paramètres.
 //
+import type { ReactNode } from "react";
 import { Bug, Bell, User, Cctv, Files, Palette } from "lucide-react";
 
 export const routes: {
 	id: string;
-	icon: JSX.Element;
+	icon: ReactNode;
 	href: string;
 }[] = [
 	{