Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keyword annotation feature #34

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Implement keyword annotation feature #34

merged 6 commits into from
Apr 14, 2023

Conversation

oriole-pub
Copy link
Collaborator

@oriole-pub oriole-pub commented Apr 13, 2023

Description

This feature implements the highlighting of terms in course articles and a preview of more content when the cursor focuses on terms

image

Remarks

The preview content of terminology currently only supports the use of MDX files, so each terminology should correspond to an MDX file.

How to use term preview in Course mdx file?

image

Review Tips

  • Vercel Comments feature allows reviewers to give direct feedback on Preview Deployments.
    Learn more about Comments in this document.
    The only requirement is that all reviewers must have a Vercel account.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckbacademy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 4:29pm

@oriole-pub oriole-pub changed the title feat: term preview feat: term content preview Apr 13, 2023
@Flouse Flouse requested review from Flouse and RetricSu April 13, 2023 07:39
src/content/terms/index.ts Outdated Show resolved Hide resolved
src/content/terms/ckb-vm.mdx Outdated Show resolved Hide resolved
src/content/courses/basic-theory/chapter_1.mdx Outdated Show resolved Hide resolved
src/content/terms/ckb.mdx Outdated Show resolved Hide resolved
@Flouse Flouse changed the title feat: term content preview Implement keyword annotation feature Apr 13, 2023
@Flouse Flouse changed the title Implement keyword annotation feature Implement keyword annotation feature Apr 13, 2023
@Flouse Flouse merged commit 66806f0 into dev Apr 14, 2023
@Flouse Flouse deleted the feat-term-preview branch April 14, 2023 02:43
@Flouse
Copy link
Owner

Flouse commented Jun 27, 2023

image

The link in the annotation view should open a new browser tab by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants