Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group tabs - select first tab after navigation #1552

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

bartbutenaers
Copy link
Contributor

Description

When use group tabs, the first tab is correctly loaded at the start. However when you select another tab, navigate to another page and back to the original page, then no tab is selected anymore. And as a result the page only shows the tabs but the tab content area is empty.

This PR makes sure the first tabsheet is always selected, every time you navigate to the page with the tabs:

select-first-tab

Related Issue(s)

1534

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Dec 21, 2024 that may be closed by this pull request
@joepavitt joepavitt merged commit fbc2020 into FlowFuse:main Dec 23, 2024
2 checks passed
@Paul-Reed
Copy link
Contributor

Could this be looked at again please, as it creates an annoying problem, particularly for phone/tablet users.
If I navigate to a tab to perhaps monitor energy usage, my phone screen blanks after 30 seconds, so I touch the screen to wake it up. PWA tells me that it's reconnecting, and then goes back to my first tab (as per this PR).
Then of course I have to navigate back to the energy tab to continue monitoring...
Why can't it load again on the same tab?

@bartbutenaers
Copy link
Contributor Author

@Paul-Reed
Could you create a separate issue please?
Because otherwise it will be overlooked in the flood of other issues.
And can you there also explain "as per this PR". Do you mean that this PR caused that problem?

@Paul-Reed
Copy link
Contributor

#1604 created.

Do you mean that this PR caused that problem?

I have been wrong before Bart 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Group not loading
3 participants