Added the timestamp field to ETLPostQueryOutcome (#1071)

Flowminder · Jul 12, 2019 · 17f908d · 17f908d
1 parent 52f0bbc
commit 17f908d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/flowdb/sql/04_schema_other.sql b/flowdb/sql/04_schema_other.sql
@@ -84,7 +84,8 @@ CREATE TABLE etl.post_etl_queries (
     cdr_type TEXT,
     type_of_query_or_check TEXT,
     outcome TEXT,
-    optional_comment_or_description TEXT
+    optional_comment_or_description TEXT,
+    timestamp TIMESTAMP WITH TIME ZONE,
 );
 
 COMMENT ON TABLE etl.post_etl_queries

diff --git a/flowetl/etl/etl/model.py b/flowetl/etl/etl/model.py
@@ -115,6 +115,7 @@ class ETLPostQueryOutcome(Base):
     type_of_query_or_check = Column(String)
     outcome = Column(String)
     optional_comment_or_description = Column(String)
+    timestamp = Column(DateTime(timezone=True))
 
     def __init__(
         self,
@@ -131,6 +132,7 @@ def __init__(
         self.type_of_query_or_check = type_of_query_or_check
         self.outcome = outcome
         self.optional_comment_or_description = optional_comment_or_description
+        self.timestamp = pendulum.utcnow()
 
     @classmethod
     def set_outcome(

diff --git a/flowetl/etl/tests/test_postetl_query_outcome.py b/flowetl/etl/tests/test_postetl_query_outcome.py
@@ -27,14 +27,18 @@ def test_can_set_outcome(session):
         "optional_comment_or_description": "Optional description",
     }
 
-    ETLPostQueryOutcome.set_outcome(
-        cdr_type=query_data["cdr_type"],
-        cdr_date=query_data["cdr_date"],
-        type_of_query_or_check=query_data["type_of_query_or_check"],
-        outcome=query_data["outcome"],
-        optional_comment_or_description=query_data["optional_comment_or_description"],
-        session=session,
-    )
+    now = pendulum.parse("2016-01-01")
+    with patch("pendulum.utcnow", lambda: now):
+        ETLPostQueryOutcome.set_outcome(
+            cdr_type=query_data["cdr_type"],
+            cdr_date=query_data["cdr_date"],
+            type_of_query_or_check=query_data["type_of_query_or_check"],
+            outcome=query_data["outcome"],
+            optional_comment_or_description=query_data[
+                "optional_comment_or_description"
+            ],
+            session=session,
+        )
 
     rows = session.query(ETLPostQueryOutcome).all()
     assert len(rows) == 1
@@ -44,6 +48,7 @@ def test_can_set_outcome(session):
     assert row.cdr_date == query_data["cdr_date"]
     assert row.type_of_query_or_check == query_data["type_of_query_or_check"]
     assert row.outcome == query_data["outcome"]
+    assert row.timestamp == now
     assert (
         row.optional_comment_or_description
         == query_data["optional_comment_or_description"]