Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception in TotalNetworkObjects #108

Closed
jc-harrison opened this issue Oct 5, 2018 · 1 comment · Fixed by #649
Closed

Unhandled exception in TotalNetworkObjects #108

jc-harrison opened this issue Oct 5, 2018 · 1 comment · Fixed by #649
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine

Comments

@jc-harrison
Copy link
Member

Description
TotalNetworkObjects doesn't complain when initialised with level="lat-lon" and either network_object="versioned-cell" or network_object="versioned-site", but calling head() raises the following errors:

AttributeError: 'TotalNetworkObjects' object has no attribute '_df'

During handling of the above exception, another exception occurred:

ProgrammingError: column reference "lat" is ambiguous
LINE 5:                 (SELECT lat,lon, location_id,version,lon,lat...
                                ^

This only happens with level="lat-lon", and is not a problem when network_object="cell".

To Reproduce

tno = TotalNetworkObjects(start='2016-01-01', stop='2016-01-07', network_object="versioned-cell", level="lat-lon")
tno.head()

Expected behavior
I'm not sure what the correct behaviour should be, but I guess this should either work or an exception should be raised by __init__().

@greenape
Copy link
Member

nice.. duplicate lat & Lon column and ambiguity because versioned-x carries a lat-lon. Either needs a special case to drop those cols from the versioned-x inner query, or to not accept lat-lon. Think former is better, because this query essentially lets you ask what cells are alive per tower?

@greenape greenape transferred this issue from another repository Nov 27, 2018
@greenape greenape added bug Something isn't working FlowMachine Issues related to FlowMachine labels Nov 27, 2018
greenape added a commit that referenced this issue Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants