Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "return" statement in TopUpBalance._make_query #1412

Closed
flow-mr-t opened this issue Oct 15, 2019 · 0 comments
Closed

Missing "return" statement in TopUpBalance._make_query #1412

flow-mr-t opened this issue Oct 15, 2019 · 0 comments
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine good first issue Good for newcomers

Comments

@flow-mr-t
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.
In the class TopUpBalance._make_query near the mention of "mode" the code snippet appears to need a 'return sql' that is not present. It not being present means the code tumbles through and overwrites the variable sql.

Product
Which part of FlowKit are you reporting an issue with?
FlowMachine

Version
Version(s) of the product affected.
Spotted in GitHub in the most recent file.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

N/A - just look in the source code.

Expected behavior
A clear and concise description of what you expected to happen.
I believe the code intends to return with the constructed sql.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
Found as part of an investigation into work for World Bank (poverty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants