Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-blocking 'get_result' #2199

Closed
jc-harrison opened this issue Mar 24, 2020 · 2 comments · Fixed by #2365
Closed

Non-blocking 'get_result' #2199

jc-harrison opened this issue Mar 24, 2020 · 2 comments · Fixed by #2365
Labels
enhancement New feature or request FlowClient Issues related to FlowClient

Comments

@jc-harrison
Copy link
Member

APIQuery.get_result is a blocking method. Would be good to also have a non-blocking version.
@jc-harrison jc-harrison added enhancement New feature or request FlowClient Issues related to FlowClient labels Mar 24, 2020
@jc-harrison
Copy link
Member Author

Related: #1905

@greenape
Copy link
Member

I think the most sensible way to achieve non-blocking in this context is definitely asyncio, but that will require a parallel client I think - apart from anything else, because to achieve this polling you'd want to use await-able sleep rather than blocking sleep.

@greenape greenape mentioned this issue Apr 20, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request FlowClient Issues related to FlowClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Asyncio flowclient Flowminder/FlowKit
2 participants
@greenape @jc-harrison