Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncio flowclient #2365

Merged
merged 21 commits into from
Apr 30, 2020
Merged

Asyncio flowclient #2365

merged 21 commits into from
Apr 30, 2020

Conversation

greenape
Copy link
Member

@greenape greenape commented Apr 20, 2020

Closes #2199

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Adds a parallel asyncio version of flowclient.

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #2365 into master will decrease coverage by 0.47%.
The diff coverage is 83.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   95.46%   94.99%   -0.48%     
==========================================
  Files         235      241       +6     
  Lines        9060     9242     +182     
  Branches      827      844      +17     
==========================================
+ Hits         8649     8779     +130     
- Misses        292      338      +46     
- Partials      119      125       +6     
Flag Coverage Δ
#autoflow_unit_tests 92.91% <ø> (ø)
#flowapi_unit_tests 82.10% <ø> (ø)
#flowauth_unit_tests 94.75% <ø> (ø)
#flowclient_unit_tests 76.83% <78.35%> (+2.78%) ⬆️
#flowetl_unit_tests 100.00% <ø> (ø)
#flowkit_jwt_generator_unit_tests 100.00% <ø> (ø)
#flowmachine_unit_tests 91.44% <ø> (ø)
#integration_tests 72.59% <67.28%> (-0.11%) ⬇️
Impacted Files Coverage Δ
flowclient/flowclient/connection.py 48.88% <48.88%> (ø)
flowclient/flowclient/async_client.py 93.65% <93.65%> (ø)
flowclient/flowclient/aggregates.py 95.83% <100.00%> (ø)
flowclient/flowclient/api_query.py 100.00% <100.00%> (ø)
flowclient/flowclient/async_api_query.py 100.00% <100.00%> (ø)
flowclient/flowclient/async_connection.py 100.00% <100.00%> (ø)
flowclient/flowclient/client.py 84.92% <100.00%> (-6.44%) ⬇️
flowclient/flowclient/errors.py 100.00% <100.00%> (ø)
flowclient/flowclient/query_specs.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcaba4e...ac7bccb. Read the comment docs.

@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient labels Apr 20, 2020
@cypress
Copy link

cypress bot commented Apr 21, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit ac7bccb
Started Apr 30, 2020 8:19 PM
Ended Apr 30, 2020 8:21 PM
Duration 02:27 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@greenape greenape force-pushed the asyncio-flowclient branch 2 times, most recently from eb19861 to 98b2147 Compare April 21, 2020 19:00
@greenape greenape marked this pull request as ready for review April 22, 2020 14:03
@greenape greenape force-pushed the asyncio-flowclient branch 4 times, most recently from 2ec5332 to 9801520 Compare April 27, 2020 14:12
@greenape greenape force-pushed the asyncio-flowclient branch from f56e514 to ac7bccb Compare April 30, 2020 20:11
@greenape greenape merged commit 3a82591 into master Apr 30, 2020
@greenape greenape deleted the asyncio-flowclient branch April 30, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowClient Issues related to FlowClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-blocking 'get_result'
1 participant