Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flowmachine server should handle non-int env vars for server thread pool size #2304

Closed
greenape opened this issue Apr 8, 2020 · 0 comments · Fixed by #2305
Closed

Flowmachine server should handle non-int env vars for server thread pool size #2304

greenape opened this issue Apr 8, 2020 · 0 comments · Fixed by #2305
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented Apr 8, 2020

At present, a non-int value will get passed straight into ThreadPoolExecutor, which will lead to an error. What it should do, is set thread_pool_size = None.
@greenape greenape added bug Something isn't working FlowMachine Issues related to FlowMachine labels Apr 8, 2020
greenape added a commit that referenced this issue Apr 8, 2020
@greenape
Fix #2304
b7aa053
@greenape greenape mentioned this issue Apr 8, 2020
Merged
8 tasks
greenape added a commit that referenced this issue Apr 13, 2020
@greenape
Fix #2304
4953984
greenape added a commit that referenced this issue Apr 14, 2020
@greenape
Fix #2304
8c3e608
greenape added a commit that referenced this issue Apr 20, 2020
@greenape
Fix #2304
334a306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitize threadpool env var Flowminder/FlowKit
1 participant
@greenape