Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose PerSubscriberAggregate #4581

Open
jc-harrison opened this issue Nov 22, 2021 · 0 comments · May be fixed by #4590
Open

Expose PerSubscriberAggregate #4581

jc-harrison opened this issue Nov 22, 2021 · 0 comments · May be fixed by #4590
Assignees
Labels
FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@jc-harrison
Copy link
Member

jc-harrison commented Nov 22, 2021

Expose PerSubscriberAggregate through the API, and add a corresponding flowclient query spec. This query should be exposed as a subscriber metric that can be used in 'joined_spatial_aggregate' and 'histogram_aggregation'.

The 'subscriber_query' parameter should accept any subscriber metric query, or a union of subscriber metric queries. Given that Union is not exposed through the API, and a general Union would not be suitable here (only a Union of the accepted subscriber metric queries), I'd suggest we could allow a list of subscriber metric queries as input for this parameter (similar to modal_location taking a list of daily locations), and construct the union internally.

I'd also suggest that we don't expose the 'agg_column' parameter, and instead hard-code it to 'value'.

@jc-harrison jc-harrison mentioned this issue Nov 22, 2021
5 tasks
@jc-harrison jc-harrison added FlowAPI Issues related to the FlowKit API FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine P-Now and removed FlowAPI Issues related to the FlowKit API labels Nov 22, 2021
@Thingus Thingus self-assigned this Nov 22, 2021
@Thingus Thingus linked a pull request Nov 22, 2021 that will close this issue
8 tasks
@jc-harrison jc-harrison added P-Later and removed P-Now labels Nov 25, 2021
@greenape greenape removed the P-Later label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants