Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CoalescedLocation #4585

Closed
Tracked by #4578
jc-harrison opened this issue Nov 22, 2021 · 1 comment · Fixed by #4647
Closed
Tracked by #4578

Expose CoalescedLocation #4585

jc-harrison opened this issue Nov 22, 2021 · 1 comment · Fixed by #4647
Assignees
Labels
FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@jc-harrison
Copy link
Member

jc-harrison commented Nov 22, 2021

Once #4584 is addressed, we'd like to be able to use FlowAPI to run a query which uses a query of this new kind as the "fallback location" in a CoalescedLocation query. This requires us to Expose CoalescedLocation and the new query class from #4584 through the API - either as two separate query schemas (with the new query kind an allowed input to 'coalesced_location') or combined into a single exposed query. Add the new query schema(s) to ReferenceLocationSchema, and add corresponding flowclient query specs.

@jc-harrison jc-harrison mentioned this issue Nov 22, 2021
5 tasks
@jc-harrison jc-harrison added FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine P-Now labels Nov 22, 2021
@jc-harrison jc-harrison changed the title Expose CoalescedLocation and new query class Expose CoalescedLocation Nov 22, 2021
@jc-harrison
Copy link
Member Author

jc-harrison commented Nov 25, 2021

I suggest that for now we roll the new query from #4584 into the exposed CoalescedLocation endpoint, so the parameters would be:

  • preferred_location (e.g. a MajorityLocation query)
  • fallback_location (e.g. a different MajorityLocation query)
  • subscriber_location_weights (e.g. a LocationVisits query)
  • weight_threshold (a number)
    The query would then join fallback_location to subscriber_location_weights, subset to weight > weight_threshold, and use that as the fallback location in a CoalescedLocation query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants