Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labelled spatial aggregates #4668

Closed
Tracked by #4615
jc-harrison opened this issue Dec 6, 2021 · 3 comments · Fixed by #4677
Closed
Tracked by #4615

Labelled spatial aggregates #4668

jc-harrison opened this issue Dec 6, 2021 · 3 comments · Fixed by #4677
Assignees
Labels
enhancement New feature or request FlowMachine Issues related to FlowMachine

Comments

@jc-harrison
Copy link
Member

jc-harrison commented Dec 6, 2021

Add equivalents of SpatialAggregate and Flows, which disaggregate counts according to per-subscriber categories defined in a specified sub-query (e.g. MobilityClassification - see #4666). The aggregate queries should take a subscriber_labels argument in addition to the subscriber-locations queries, join on subscriber, and group by label as well as location.

In the case of Flows, we could consider allowing two separate sets of labels (i.e. subscribers labelled differently at the "from" and "to" locations). It's not clear whether that would be useful in practice, though (and if it was, the same could be achieved by using a single subscriber_labels query that assigns a label-pair to each subscriber), so in the first instance a single set of labels should be sufficient.

This could be achieved using new classes LabelledSpatialAggregate and LabelledFlows, or by adding an optional subscriber_labels parameter to the existing SpatialAggregate and Flows classes.

@jc-harrison jc-harrison added enhancement New feature or request FlowMachine Issues related to FlowMachine P-Now labels Dec 6, 2021
@jc-harrison jc-harrison changed the title Introduce equivalents of SpatialAggregate and Flows, which disaggregate counts according to categories defined in a specified sub-query. Labelled spatial aggregate / flows. Dec 6, 2021
@Thingus Thingus self-assigned this Dec 6, 2021
@greenape
Copy link
Member

greenape commented Dec 7, 2021

Is this more generally applicable than these two classes? i.e. all of the od variants (ex: trips, consec, meaningful locations), and all aggregates to a location (ex: TLE, unique subs, unmoving counts, introversion etc.)?

@jc-harrison
Copy link
Member Author

Is this more generally applicable than these two classes? i.e. all of the od variants (ex: trips, consec, meaningful locations), and all aggregates to a location (ex: TLE, unique subs, unmoving counts, introversion etc.)?

Yes, I suppose this could apply to all aggregates (at least, all aggregates over subscribers - which is just about everything except TotalNetworkObjects, I think).

@jc-harrison
Copy link
Member Author

Closely-related issue: #2023

@Thingus Thingus changed the title Labelled spatial aggregate / flows. Labelled spatial aggregates Dec 8, 2021
@mergify mergify bot closed this as completed in #4677 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants