Implementing labelling disaggregation

[Thingus]

Closes #4668

I have:

• Formatted any Python files with black
• Brought the branch up to date with master
• Added any relevant Github labels
• Added tests for any new additions
• Added or updated any relevant documentation
• Added an Architectural Decision Record (ADR), if appropriate
• Added an MPLv2 License Header if appropriate
• Updated the Changelog

Description

Adds paramater to spatial_aggregate that takes a query containing subscribers + labels to disaggregate by

[cypress]

---

Test summary

43 • 0 • 0 • 0 • 0

---

Run details

Project	FlowAuth
Status	Passed
Commit	0262577
Started	Dec 9, 2021 9:37 AM
Ended	Dec 9, 2021 9:42 AM
Duration	04:59 💡
OS	Linux Debian - 10.5
Browser	Electron 94

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[codecov]

Codecov Report

Merging #4677 (0262577) into master (906bdf4) will increase coverage by 0.02%.
The diff coverage is 98.18%.

@@            Coverage Diff             @@
##           master    #4677      +/-   ##
==========================================
+ Coverage   93.46%   93.48%   +0.02%     
==========================================
  Files         265      267       +2     
  Lines       10444    10496      +52     
  Branches     1236     1247      +11     
==========================================
+ Hits         9761     9812      +51     
- Misses        550      551       +1     
  Partials      133      133              

Flag	Coverage Δ
autoflow_unit_tests	93.03% <ø> (ø)
flowapi_unit_tests	72.76% <ø> (ø)
flowauth_unit_tests	78.41% <ø> (ø)
flowclient_unit_tests	74.57% <ø> (ø)
flowetl_unit_tests	95.49% <ø> (ø)
flowkit_jwt_generator_unit_tests	95.10% <ø> (ø)
flowmachine_unit_tests	91.08% <98.18%> (+0.05%)	⬆️
integration_tests	66.18% <5.45%> (-0.39%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ne/features/location/labelled_spatial_aggregate.py	97.05% <97.05%> (ø)
flowmachine/flowmachine/core/spatial_unit.py	95.49% <100.00%> (ø)
...es/location/redacted_labelled_spatial_aggregate.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906bdf4...0262577. Read the comment docs.

[Thingus]

Does this need an ADR for the redaction strategy?

[jc-harrison]

Does this need an ADR for the redaction strategy?

Yes, that's not a bad idea. We're likely to need to make similar decisions again, so recording the reasoning behind this choice would be good.

[jc-harrison]

👍