Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Model #5168

Closed
greenape opened this issue May 23, 2022 · 0 comments · Fixed by #5172
Closed

Remove Model #5168

greenape opened this issue May 23, 2022 · 0 comments · Fixed by #5172
Labels
FlowMachine Issues related to FlowMachine refactoring

Comments

@greenape
Copy link
Member

We should, I think, remove Model and ModelResult from flowmachine.

They're a neat trick, but in practice have not been used. We would be better off dealing with 'I want to run a python thing and put it in the db' through a more considered route (e.g. just run the damn python in the db). They also introduce a bunch of 'clever' code that is a maintenance headache.

Would also make unpicking #5140 a little easier.

@greenape greenape added FlowMachine Issues related to FlowMachine refactoring labels May 23, 2022
greenape added a commit that referenced this issue May 23, 2022
greenape added a commit that referenced this issue May 24, 2022
@greenape greenape mentioned this issue May 24, 2022
8 tasks
greenape added a commit that referenced this issue May 30, 2022
greenape added a commit that referenced this issue Jun 10, 2022
@mergify mergify bot closed this as completed in #5172 Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowMachine Issues related to FlowMachine refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant