Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API route for location introversion #577

Closed
9 tasks
greenape opened this issue Apr 4, 2019 · 1 comment
Closed
9 tasks

Add API route for location introversion #577

greenape opened this issue Apr 4, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request FlowAuth Issues related to FlowAuth FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

greenape commented Apr 4, 2019

flowmachine.features.location.location_introversion.LocationIntroversion should have an exposed API route.

I'm thinking same parameterisation as the other exposed routes - start, stop, aggregation unit + direction, but I'd like direction to be optional with default both.

  • Add LocationIntroversionExposed class
  • Add marshmallow schema
  • Add schema to FlowmachineQuerySchema
  • Add flowclient function
  • Add tests to integration tests
    • Add test case to test_get_query_params
    • Add test case to test_run_query
  • Add query endpoint to Flowauth demo data
  • Update approval test data for integration tests
@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowAuth Issues related to FlowAuth FlowMachine Issues related to FlowMachine labels Apr 4, 2019
@maxalbert
Copy link
Contributor

Thinking about it, the purpose of the integration tests test_get_query_params and test_run_query (in the files integration_tests/tests/flowmachine_server_tests/test_action_get_params.py and integration_tests/tests/flowmachine_server_tests/test_action_run_query.py) is to exercise the respective action handlers but should be agnostic of any specific queries.

Instead, if we want to test the specific queries and their parameters I suggest to add a test to integration_tests/tests/test_queries.py, which exercises the individual queries through their respective flowclient functions.

At the moment the test files and test names don't always make it very clear what their purpose is and which parts of the code they are supposed to exercise. We should rename the above ones in particular to clarify this. I have opened #584 to track this.

@OwlHute OwlHute mentioned this issue Apr 5, 2019
8 tasks
@greenape greenape closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowAuth Issues related to FlowAuth FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Development

No branches or pull requests

3 participants