Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak names of tests and test files to make their purpose clearer #584

Open
maxalbert opened this issue Apr 5, 2019 · 0 comments
Open
Labels
tests Issues relating to tests

Comments

@maxalbert
Copy link
Contributor

Related to my comment in #577, some of the tests and test files are quite generically named (or perhaps even slightly mis-named) so that the purpose of the tests isn't very clear. This may accidentally lead to the addition of tests that are either superfluous or don't actually test what they are supposed to tests.

In particular, the tests in integration_tests/tests/flowmachine_server_tests/test_action_*.py are supposed to test the various action handlers rather than any specific queries, but this is not apparent.

Similarly, it is not obvious that integration_tests/tests/test_queries.py exercises the queries through flowclient.

There are likely a few other such cases.

@greenape greenape added the tests Issues relating to tests label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues relating to tests
Projects
None yet
Development

No branches or pull requests

2 participants