Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table aggregates.aggregates is a bad name! #587

Closed
josh-gree opened this issue Apr 5, 2019 · 1 comment · Fixed by #2053
Closed

Table aggregates.aggregates is a bad name! #587

josh-gree opened this issue Apr 5, 2019 · 1 comment · Fixed by #2053
Labels
FlowDB Issues related to FlowDB

Comments

@josh-gree
Copy link
Contributor

Change table name for aggregates.aggregates to something more meaningful that reflects its use as a place for storing information about the process of calculating aggregates rather than aggregates themselves.
@josh-gree josh-gree added the FlowDB Issues related to FlowDB label Apr 5, 2019
@maxalbert
Copy link
Contributor

Just wondering if we should actually rename the schema rather than the table? We could call it etl_metadata.aggregates? @josh-gree will know best how this is likely to fit in with the upcoming ETL changes, and if appropriate we can roll it into one of the next PRs.

greenape added a commit that referenced this issue Mar 3, 2020
@greenape
Remove some unused schemas
3a67a75 
and close #587
@greenape greenape mentioned this issue Mar 3, 2020
Merged
8 tasks
greenape added a commit that referenced this issue Mar 10, 2020
@greenape
Remove some unused schemas
c37256f 
and close #587
@mergify mergify bot closed this as completed in #2053 Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FlowDB Issues related to FlowDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some unused schemas Flowminder/FlowKit
2 participants
@maxalbert @josh-gree