Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter names in connect() are inconsistent with env var names #728

Closed
maxalbert opened this issue May 9, 2019 · 0 comments · Fixed by #729
Closed

Parameter names in connect() are inconsistent with env var names #728

maxalbert opened this issue May 9, 2019 · 0 comments · Fixed by #729
Labels
FlowMachine Issues related to FlowMachine refactoring

Comments

@maxalbert
Copy link
Contributor

Recent PR's (esp. #610) have done a great job at harmonising the names of env vars and parameters. However, flowmachine.connect() still has a couple of the old names left over which are slightly inconsistent with the new env var names.

For consistency, these should be renamed as follows:

  • db_port -> flowdb_port
  • db_user -> flowdb_user
  • db_pass -> flowdb_password
  • db_host -> flowdb_host
  • db_connection_pool_size -> flowdb_connection_pool_size
  • db_connection_pool_overflow -> flowdb_connection_pool_overflow
@maxalbert maxalbert added FlowMachine Issues related to FlowMachine refactoring labels May 9, 2019
@greenape greenape closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowMachine Issues related to FlowMachine refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants