Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters in connect() #729

Merged
merged 5 commits into from
May 9, 2019
Merged

Rename parameters in connect() #729

merged 5 commits into from
May 9, 2019

Conversation

maxalbert
Copy link
Contributor

Closes #728

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Renames the parameters in connect() as suggested in #728, and also makes them keyword-only arguments.

@maxalbert maxalbert added FlowMachine Issues related to FlowMachine refactoring labels May 9, 2019
@maxalbert maxalbert added the ready-to-merge Label indicating a PR is OK to automerge label May 9, 2019
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #729 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         130      130           
  Lines        6473     6473           
  Branches      683      683           
=======================================
  Hits         6068     6068           
  Misses        283      283           
  Partials      122      122
Impacted Files Coverage Δ
flowmachine/flowmachine/core/init.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0eeaf...7219c6b. Read the comment docs.

@mergify mergify bot merged commit 6485cc5 into master May 9, 2019
@mergify mergify bot deleted the rename-parameters branch May 9, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter names in connect() are inconsistent with env var names
2 participants