Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base compose file won't work with docker-compose up #843

Closed
greenape opened this issue May 23, 2019 · 0 comments · Fixed by #1057
Closed

Base compose file won't work with docker-compose up #843

greenape opened this issue May 23, 2019 · 0 comments · Fixed by #1057
Assignees
@danwilliams
Labels
deployment docker

Comments

@greenape
Copy link
Member

Via @josh-gree

The current compose file will just error if used directly with docker-compose up, which isn't ideal.

What would work as an alternative, is to split out the three flowdb containers into two additional compose files, so you can override the flowdb container.

e.g. docker-compose up gives you a bare flowdb, docker-compose up -f docker-compose.yml -f docker-compose-testdata.yml gives you testdata etc.
@danwilliams danwilliams self-assigned this Jul 8, 2019
danwilliams added a commit that referenced this issue Jul 9, 2019
@danwilliams
Split the docker-compose files into three for flowdb (#843)
3f2c13c
danwilliams added a commit that referenced this issue Jul 9, 2019
@danwilliams
Updated the Makefile for the two separated flowdb containers (#843)
24c5491
danwilliams added a commit that referenced this issue Jul 9, 2019
@danwilliams
Updated the up/up-no_build/down rules to include the new files (#843)
c429120
danwilliams added a commit that referenced this issue Jul 9, 2019
@danwilliams
Extracted the docker-compose commands at the top to be reused (#843)
952e910
danwilliams added a commit that referenced this issue Jul 9, 2019
@danwilliams
Updated the quick_start with temp folder solution for dockerfiles (#843)
03d9a8c 
Because there are multiple docker-compose yml files to be taken into
account now, we needed them _available_ somewhere, so they are now
getting downloaded into a temp folder that gets cleaned up on exit.
danwilliams added a commit that referenced this issue Jul 9, 2019
@danwilliams
Added changelog entry (#843)
2223536
@danwilliams danwilliams mentioned this issue Jul 9, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwilliams danwilliams

Labels
deployment docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tasks/843 flowdb compose duplicates Flowminder/FlowKit
2 participants
@danwilliams @greenape