Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose UniqueLocationCounts via api #949

Closed
11 tasks
greenape opened this issue Jun 18, 2019 · 0 comments · Fixed by #979
Closed
11 tasks

Expose UniqueLocationCounts via api #949

greenape opened this issue Jun 18, 2019 · 0 comments · Fixed by #979
Assignees
@BhavinPanch
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

  • Add marshmallow spec for UniqueLocationCounts
  • Add to allowable joined aggregate queries
  • Add flowclient function unique_location_counts(*, start, stop, level, subscriber_subset)
  • Add test to integration_tests/tests/test_queries.py
  • Update acceptance tests
    • integration_tests/tests/flowapi_tests/test_api_spec.py
    • integration_tests/tests/flowmachine_server_tests/test_server.py
  • Update docs/source/4-developer.md with newly added query
  • Change returned column name to value from unique_location_counts in UniqueLocationCounts in SQL and column_names attribute
  • Update tests using UniqueLocationCounts to reflect changed column name
  • Update Changelog
@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine labels Jun 18, 2019
@BhavinPanch BhavinPanch mentioned this issue Jun 25, 2019
Merged
8 tasks
@mergify mergify bot closed this as completed in #979 Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BhavinPanch BhavinPanch

Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flowmachine unique location count Flowminder/FlowKit
2 participants
@greenape @BhavinPanch