Flowmachine unique location count #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…both location and metric
greenape
requested changes
Jun 25, 2019
flowclient/flowclient/client.py
Outdated
|
|
||
|
|
||
| def unique_location_counts( | ||
| *, start_date, end_date, aggregation_unit, subscriber_subset=None |
There was a problem hiding this comment.
These need to be type annotated.
| @@ -134,13 +134,13 @@ def _make_query(self): | |||
| get_columns_for_level(self.ul.level, self.ul.column_name) | |||
| ) | |||
| sql = """ | |||
There was a problem hiding this comment.
Can we change this to an f-string while we're here?
greenape
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 93.33% 93.36% +0.02%
==========================================
Files 136 137 +1
Lines 6861 6892 +31
Branches 697 699 +2
==========================================
+ Hits 6404 6435 +31
+ Misses 333 332 -1
- Partials 124 125 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
===========================================
+ Coverage 67.01% 93.36% +26.35%
===========================================
Files 136 137 +1
Lines 6861 6892 +31
Branches 697 699 +2
===========================================
+ Hits 4598 6435 +1837
+ Misses 2109 332 -1777
+ Partials 154 125 -29
Continue to review full report at Codecov.
|
greenape
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #949
I have:
Unique location count was added to FlowAPI's joined_spatial_aggregate endpoint.