Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EventCount via api #992

Closed
8 tasks
greenape opened this issue Jun 27, 2019 · 0 comments · Fixed by #1023
Closed
8 tasks

Expose EventCount via api #992

greenape opened this issue Jun 27, 2019 · 0 comments · Fixed by #1023
Assignees
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine

Comments

@greenape
Copy link
Member

  • Add marshmallow spec for EventCount
  • Add to allowable joined aggregate queries
  • Add flowclient function event_count(*, start, stop, direction, event_types, subscriber_subset)
  • Add test to integration_tests/tests/test_queries.py
  • Update acceptance tests
    • integration_tests/tests/flowapi_tests/test_api_spec.py
    • integration_tests/tests/flowmachine_server_tests/test_server.py
  • Update Changelog

event_types should in schema be EventTypes(), and take None being passed into the client function as meaning 'all' when it actually gets executed as with LocationEvenCounts

@greenape greenape added enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine labels Jun 27, 2019
@mergify mergify bot closed this as completed in #1023 Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowClient Issues related to FlowClient FlowMachine Issues related to FlowMachine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants