Flowmachine event count #1023
Merged
Flowmachine event count #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenape
added
enhancement
greenape
requested changes
Jul 2, 2019
flowclient/flowclient/client.py
Outdated
| start: str, | ||
| stop: str, | ||
| direction: str = "both", | ||
| event_types: Union[None, List[str]] = None, |
There was a problem hiding this comment.
Can actually write this as Optional[List[str]] which is equivalent to Union[None, ..] and maybe a bit clearer.
Co-Authored-By: Jonathan Gray <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
+ Coverage 93.93% 93.96% +0.02%
==========================================
Files 141 142 +1
Lines 6930 6957 +27
Branches 693 693
==========================================
+ Hits 6510 6537 +27
Misses 309 309
Partials 111 111
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
+ Coverage 93.93% 93.96% +0.02%
==========================================
Files 141 142 +1
Lines 6930 6957 +27
Branches 693 693
==========================================
+ Hits 6510 6537 +27
Misses 309 309
Partials 111 111
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
+ Coverage 93.93% 93.96% +0.02%
==========================================
Files 141 142 +1
Lines 6930 6957 +27
Branches 693 693
==========================================
+ Hits 6510 6537 +27
Misses 309 309
Partials 111 111
Continue to review full report at Codecov.
|
greenape
requested changes
Jul 3, 2019
CHANGELOG.md
Outdated
| @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| - Added a `Geography` query class, to get geography data for a spatial unit. | |||
| - FlowAPI's 'joined_spatial_aggregate' endpoint now exposes unique location counts.[#949](https://github.com/Flowminder/FlowKit/issues/949) | |||
| - FlowAPI's 'joined_spatial_aggregate' endpoint now exposes subscriber degree.[#969](https://github.com/Flowminder/FlowKit/issues/969) | |||
| - FlowAPI's 'joined_spatial_aggregate' endpoint now exposes event counts.[#992](https://github.com/Flowminder/FlowKit/issues/992) | |||
docs/source/developer/developer.md
Outdated
| @@ -136,6 +136,9 @@ At present, the following query types are accessible through FlowAPI: | |||
|
|
|||
| Count of mobile phone cells per area active based on CDR traffic within a time period, broken down into time buckets. | |||
|
|
|||
| -`event_count` | |||
|
|
|||
| Count of event for individual subscribers in a time period. | |||
There was a problem hiding this comment.
Suggested change
| Count of event for individual subscribers in a time period. | |
| Count of events (optionally of specific types) for individual subscribers in a time period. |
flowclient/flowclient/client.py
Outdated
| direction : {"in", "out", "both"}, default "both" | ||
| Optionally, include only ingoing or outbound calls/texts. Can be one of "in", "out" or "both". | ||
| event_types : list of str, optional | ||
| The event types for which to return available dates (for example: ["calls", "sms"]). |
There was a problem hiding this comment.
Suggested change
| The event types for which to return available dates (for example: ["calls", "sms"]). | |
| The event types to include in the count (for example: ["calls", "sms"]). |
flowclient/flowclient/client.py
Outdated
| Optionally, include only ingoing or outbound calls/texts. Can be one of "in", "out" or "both". | ||
| event_types : list of str, optional | ||
| The event types for which to return available dates (for example: ["calls", "sms"]). | ||
| If None, return available dates for all available event types. |
There was a problem hiding this comment.
Suggested change
| If None, return available dates for all available event types. | |
| If None, include all event types in the count. |
greenape
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #992
I have:
Event count values are exposed through FlowAPI's Joined Spatial Aggregate.