-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowmachine pareto #1044
Flowmachine pareto #1044
Conversation
query_kind = fields.String(validate=OneOf(["pareto_interactions"])) | ||
start = fields.Date(required=True) | ||
stop = fields.Date(required=True) | ||
proportion = fields.Float(required=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add a validate
parameter here to ensure that proportion
is a value (strictly) between 0.0 and 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
A couple of minor inline comments, then this is ready to merge (after resolving merge conflicts due to a previous PR having been merged already).
Co-Authored-By: maxalbert <[email protected]>
Co-Authored-By: maxalbert <[email protected]>
Co-Authored-By: maxalbert <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
- Coverage 91.23% 90.02% -1.22%
==========================================
Files 141 16 -125
Lines 6786 1393 -5393
Branches 662 57 -605
==========================================
- Hits 6191 1254 -4937
+ Misses 483 131 -352
+ Partials 112 8 -104
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
+ Coverage 94.03% 94.06% +0.02%
==========================================
Files 144 145 +1
Lines 7030 7055 +25
Branches 694 694
==========================================
+ Hits 6611 6636 +25
Misses 309 309
Partials 110 110
Continue to review full report at Codecov.
|
Thanks for the changes! 👍 Nearly ready to merge, the only missing bit is to add a |
Sorry, my bad. Github was pointing me to an old revision, but I saw you already changed this so this is good to go. Thanks! |
Closes #1012
I have:
Expose Pareto interactions via FlowAPI's joined spatial aggregate endpoint.