-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks/1019 flowetl debugging test failures #1066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 94.12% 95.21% +1.09%
==========================================
Files 186 184 -2
Lines 8300 8188 -112
Branches 784 778 -6
==========================================
- Hits 7812 7796 -16
+ Misses 347 281 -66
+ Partials 141 111 -30
Continue to review full report at Codecov.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Might be good to use this in CI to make the logs available, but not essential right now.
Closes #1019
I have:
Description
This introduces the
FLOWETL_INTEGRATION_TESTS_SAVE_AIRFLOW_LOGS
variable in an attempt to make debugging failures easier. It will save the logs to/mounts/logs
mounted on the host and also outputs all logs using Python's logging (although, this logging output is not really well formatted - not sure how it could be made better, it currently justcat
s all the logs, outputting the result).Having considered the other options as well, it seems like most (if not all) failures would be evident from the airflow logs; navigating through the Airflow's UI might be nicer but getting all the logs should be the crucial thing.