Speed #1258
Speed #1258
Conversation
Co-Authored-By: James Harrison <[email protected]>
greenape
added
FlowMachine
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
- Coverage 94.16% 94.15% -0.02%
==========================================
Files 154 154
Lines 7478 7493 +15
Branches 698 702 +4
==========================================
+ Hits 7042 7055 +13
- Misses 330 331 +1
- Partials 106 107 +1
Continue to review full report at Codecov.
|
| @@ -275,9 +275,6 @@ def _known_dates(self, table, schema): | |||
| if x.isnumeric() | |||
| ) | |||
|
|
|||
| @cached( | |||
| TTLCache(1024, 120) | |||
| ) # Many dates to cache, two minutes seems reasonable to balance db access against speed boost | |||
There was a problem hiding this comment.
Just for my understanding, what's the reason for removing this?
There was a problem hiding this comment.
Just to record the reasoning - this function is only called by available_dates, which is itself cached. The periodic update function added to server.py skips the cache for available_dates so it will always hit the db and create any table objects needed. That isn't guaranteed if this method is also cached.
…re-serve funcs get called
Co-Authored-By: James Harrison <[email protected]>
Towards #1256 but doesn't solve it.
I have:
Description
Several small tweaks which speed up creating query objects.
available_dateswhen first connecting to FlowDB to pre-createTableobjectsavailable_datesperiodically as a background thread in the server to keep that freshTablestate machines if they're already complete__version__inwrite_cache_metadata- originally necessary to avoid a circular import, but not nowpg_notifythat isn't used