Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance series query #1314

Merged
merged 15 commits into from
Oct 9, 2019
Merged

Distance series query #1314

merged 15 commits into from
Oct 9, 2019

Conversation

greenape
Copy link
Member

Closes #1313

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Adds a DistanceSeries query to flowmachine.

This outputs, per subscriber, a time series of some stat over the distances there were observed to be from a reference location, or arbitary reference point. E.g. minimum distance from 0,0 per day, or median distance from home per week.

@greenape greenape added enhancement New feature or request FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge labels Sep 25, 2019
@cypress
Copy link

cypress bot commented Sep 25, 2019



Test summary

55 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 8a6bc7c
Started Oct 9, 2019 2:34 PM
Ended Oct 9, 2019 2:38 PM
Duration 03:32 💡
OS Linux Debian - 8.11
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #1314 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   95.02%   95.02%   +<.01%     
==========================================
  Files         157      158       +1     
  Lines        7551     7593      +42     
  Branches      704      712       +8     
==========================================
+ Hits         7175     7215      +40     
- Misses        268      269       +1     
- Partials      108      109       +1
Flag Coverage Δ
#flowapi_unit_tests 82.36% <ø> (ø) ⬆️
#flowauth_unit_tests 93.65% <ø> (ø) ⬆️
#flowclient_unit_tests 78.78% <ø> (ø) ⬆️
#flowetl_unit_tests 97.35% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (ø) ⬆️
#flowmachine_unit_tests 90.89% <100%> (+0.03%) ⬆️
#integration_tests 68.17% <28.57%> (-0.32%) ⬇️
Impacted Files Coverage Δ
...flowmachine/features/subscriber/distance_series.py 100% <100%> (ø)
flowmachine/flowmachine/models/louvain.py 91.42% <0%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec261c...8a6bc7c. Read the comment docs.

@greenape greenape force-pushed the distance-series-query branch 3 times, most recently from af18564 to 0ba38e0 Compare October 2, 2019 09:21
@greenape greenape mentioned this pull request Oct 2, 2019
8 tasks
@greenape greenape force-pushed the distance-series-query branch from 0ba38e0 to b4f09c1 Compare October 3, 2019 08:57
Copy link
Contributor

@maxalbert maxalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor tweaks needed (see inline comments).

@greenape greenape force-pushed the distance-series-query branch from 47fd912 to fe40a5a Compare October 9, 2019 12:15
Copy link
Contributor

@maxalbert maxalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great now. 👍

@mergify mergify bot merged commit d5eb3ae into master Oct 9, 2019
@mergify mergify bot deleted the distance-series-query branch October 9, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distance series
2 participants