Flowetl refactoring & bug fixes #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
October 7, 2019 11:39
…ause they are fixed anyway.
… with schedule_interval
…ally pass the concurrency setting on to the DAG.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
==========================================
+ Coverage 95.01% 95.02% +<.01%
==========================================
Files 157 157
Lines 7548 7551 +3
Branches 704 704
==========================================
+ Hits 7172 7175 +3
Misses 268 268
Partials 108 108
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1375, closes #1376, closes #1377, closes #1378, closes #1379.
I have:
Description
The
default_argssection has been removed from the FlowETLconfig.yml. Similarly, we don't pass in adefault_argsdict toconstruct_etl_dag()any more - instead, the values forownerandstart_dateare now hard-coded inside that function because they don't need to change.We now create DAGs only for those CDR types that are present in
config.yml.The config is now always validated and default values filled in when reading the
config.ymlfile.The
concurrencysetting fromconfig.ymlis now passed on to the DAG during creation, using themax_active_runs_per_dagparameter. Note that Airflow has a plethora of concurrency/parallelism settings, which can be a bit confusing (see discussions here, here, here and here, among other places), butmax_active_runs_per_dagseems to be the right setting for this purpose.The FlowETL deployment example has been updated so that it works when simply following the instructions.