Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp qa checks #2628

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Timestamp qa checks #2628

merged 8 commits into from
Jun 2, 2020

Conversation

jc-harrison
Copy link
Member

Closes #2627

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Adds two new FlowETL QA checks: earliest_timestamp.sql and latest_timestamp.sql.

@jc-harrison jc-harrison added enhancement New feature or request FlowETL labels Jun 2, 2020
Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@cypress
Copy link

cypress bot commented Jun 2, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 5401d74
Started Jun 2, 2020 6:08 PM
Ended Jun 2, 2020 6:11 PM
Duration 02:22 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2628   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         241      241           
  Lines        9401     9401           
  Branches      851      851           
=======================================
  Hits         8824     8824           
  Misses        448      448           
  Partials      129      129           
Flag Coverage Δ
#autoflow_unit_tests 92.99% <ø> (ø)
#flowapi_unit_tests 65.63% <ø> (ø)
#flowauth_unit_tests 84.89% <ø> (ø)
#flowclient_unit_tests 76.83% <ø> (ø)
#flowetl_unit_tests 100.00% <ø> (ø)
#flowkit_jwt_generator_unit_tests 100.00% <ø> (ø)
#flowmachine_unit_tests 91.31% <ø> (ø)
#integration_tests 71.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6dc9a...5401d74. Read the comment docs.

@jc-harrison jc-harrison added the ready-to-merge Label indicating a PR is OK to automerge label Jun 2, 2020
@mergify mergify bot merged commit bae55cc into master Jun 2, 2020
@mergify mergify bot deleted the timestamp-qa-checks branch June 2, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowETL ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA checks for time range
2 participants