Expose 'event_types' parameters #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jc-harrison
added
enhancement
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
+ Coverage 93.86% 93.88% +0.02%
==========================================
Files 241 241
Lines 9401 9435 +34
Branches 851 852 +1
==========================================
+ Hits 8824 8858 +34
Misses 448 448
Partials 129 129
Continue to review full report at Codecov.
|
greenape
requested changes
Jun 2, 2020
flowclient/flowclient/aggregates.py
Outdated
| @@ -113,6 +113,7 @@ def meaningful_locations_aggregate_spec( | |||
| aggregation_unit: str, | |||
| tower_cluster_radius: float = 1.0, | |||
| tower_cluster_call_threshold: int = 0, | |||
| event_types: Union[None, List[str]] = None, | |||
There was a problem hiding this comment.
Make it consistently Optional[List[str]]?
flowclient/flowclient/aggregates.py
Outdated
| @@ -167,6 +168,8 @@ def meaningful_locations_aggregate_spec( | |||
| more towers, and fewer clusters. | |||
| tower_cluster_call_threshold : int | |||
| Exclude towers from a subscriber's clusters if they have been used on less than this number of days. | |||
| event_types : None or list of {"calls", "sms", "mds"}, default None | |||
There was a problem hiding this comment.
Or topups?
Almost feel like worth using the str Enum trick for this.
greenape
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2631
I have:
Description
Exposes an
event_typesparameter for all queries that internally have atable/tablesparameter for selecting a subset of events tables inEventsTablesUnion.