Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes #3115

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Logging fixes #3115

merged 2 commits into from
Oct 12, 2020

Conversation

greenape
Copy link
Member

Closes #3071

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Log all query access to query run log flowapi side.

Log query run, poll, and get to query run logger
@greenape greenape added FlowAPI Issues related to the FlowKit API security labels Oct 12, 2020
@cypress
Copy link

cypress bot commented Oct 12, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 695b246
Started Oct 12, 2020 12:05 PM
Ended Oct 12, 2020 12:07 PM
Duration 02:08 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #3115 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.01%     
==========================================
  Files         249      249              
  Lines        9926     9930       +4     
  Branches      852      852              
==========================================
+ Hits         9309     9312       +3     
- Misses        494      495       +1     
  Partials      123      123              
Flag Coverage Δ
#autoflow_unit_tests 92.99% <ø> (ø)
#flowapi_unit_tests 72.62% <75.00%> (+0.01%) ⬆️
#flowauth_unit_tests 78.39% <ø> (ø)
#flowclient_unit_tests 80.25% <ø> (ø)
#flowetl_unit_tests 95.38% <ø> (ø)
#flowkit_jwt_generator_unit_tests 95.10% <ø> (ø)
#flowmachine_unit_tests 91.25% <ø> (ø)
#integration_tests 67.02% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flowapi/flowapi/query_endpoints.py 80.45% <75.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1608f04...695b246. Read the comment docs.

@greenape greenape merged commit 3cd9d42 into master Oct 12, 2020
@greenape greenape deleted the logging-fixes branch October 12, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowAPI Issues related to the FlowKit API security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlowAPI query run log
1 participant