Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made link to admin docs explicit to help Mkdocs with resolving #3156

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

geekysquirrel
Copy link

@geekysquirrel geekysquirrel commented Oct 19, 2020

Hopefully this fixes #3152

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

This updates the install.md file in the docs to fix an issue links generated by MKdocs.

@geekysquirrel geekysquirrel added bug Something isn't working docs Documentation issues labels Oct 19, 2020
@cypress
Copy link

cypress bot commented Oct 19, 2020



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 44a3fbf
Started Oct 19, 2020 6:00 PM
Ended Oct 19, 2020 6:02 PM
Duration 02:18 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #3156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3156   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files         251      251           
  Lines       10042    10042           
  Branches      858      858           
=======================================
  Hits         9391     9391           
  Misses        523      523           
  Partials      128      128           
Flag Coverage Δ
#autoflow_unit_tests 92.99% <ø> (ø)
#flowapi_unit_tests 72.84% <ø> (ø)
#flowauth_unit_tests 78.39% <ø> (ø)
#flowclient_unit_tests 80.25% <ø> (ø)
#flowetl_unit_tests 95.38% <ø> (ø)
#flowkit_jwt_generator_unit_tests 95.10% <ø> (ø)
#flowmachine_unit_tests 90.79% <ø> (ø)
#integration_tests 66.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f8893...44a3fbf. Read the comment docs.

Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that fixes it, thanks! 👍

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Oct 20, 2020
@mergify mergify bot merged commit deae5e7 into master Oct 20, 2020
@mergify mergify bot deleted the fix/3152-admin-section-link-in-docs branch October 20, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation issues ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The admin section of the docs is missing
3 participants