Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom qa checks #3489

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Fix custom qa checks #3489

merged 4 commits into from
Jan 14, 2021

Conversation

greenape
Copy link
Member

Closes #3484

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Properly adds the tags folder to the search path for collecting etl checks, and allows passing additional search paths.

@greenape greenape added bug Something isn't working enhancement New feature or request FlowETL labels Jan 14, 2021
@cypress
Copy link

cypress bot commented Jan 14, 2021



Test summary

43 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 11384b3
Started Jan 14, 2021 11:55 AM
Ended Jan 14, 2021 11:57 AM
Duration 02:34 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #3489 (11384b3) into master (5a008a4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3489   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         251      251           
  Lines       10128    10128           
  Branches      865      865           
=======================================
  Hits         9435     9435           
  Misses        562      562           
  Partials      131      131           
Flag Coverage Δ
autoflow_unit_tests 92.99% <ø> (ø)
flowapi_unit_tests 72.84% <ø> (ø)
flowauth_unit_tests 78.39% <ø> (ø)
flowclient_unit_tests 74.88% <ø> (ø)
flowetl_unit_tests 95.40% <100.00%> (ø)
flowkit_jwt_generator_unit_tests 95.10% <ø> (ø)
flowmachine_unit_tests 90.79% <ø> (ø)
integration_tests 66.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flowetl/flowetl/flowetl/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a008a4...11384b3. Read the comment docs.

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Jan 14, 2021
Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 53eae20 into master Jan 14, 2021
@mergify mergify bot deleted the fix-custom-qa-checks branch January 14, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request FlowETL ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlowETL doesn't pick up custom QA checks
2 participants