Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend trigger to cover 'CREATE TABLE AS' commands #5093

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

jc-harrison
Copy link
Member

@jc-harrison jc-harrison commented Apr 22, 2022

Closes #4714

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Extends the FlowDB "make tables in cache schema owned by flowmachine user" trigger to cover 'CREATE TABLE AS' commands as well as 'CREATE TABLE' commands, so that ownership is changed for cache tables created by storing a flowmachine query.

@jc-harrison jc-harrison added FlowMachine Issues related to FlowMachine FlowDB Issues related to FlowDB labels Apr 22, 2022
@jc-harrison jc-harrison added the ready-to-merge Label indicating a PR is OK to automerge label Apr 22, 2022
@cypress
Copy link

cypress bot commented Apr 22, 2022



Test summary

43 0 0 0Flakiness 0


Run details

Project FlowAuth
Status Passed
Commit d8e5916
Started Apr 22, 2022 4:40 PM
Ended Apr 22, 2022 4:48 PM
Duration 08:04 💡
OS Linux Debian - 10.5
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #5093 (d8e5916) into master (794c663) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5093   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files         276      276           
  Lines       10760    10760           
  Branches     1308     1308           
=======================================
  Hits        10101    10101           
  Misses        525      525           
  Partials      134      134           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ well done!

@mergify mergify bot merged commit 7fd4a08 into master Apr 22, 2022
@mergify mergify bot deleted the fix-cache-ownership-trigger branch April 22, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowDB Issues related to FlowDB FlowMachine Issues related to FlowMachine ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flowmachine should own all cache tables
2 participants