-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow country to be set using quickstart #5797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5797 +/- ##
===========================================
- Coverage 93.23% 78.39% -14.85%
===========================================
Files 277 277
Lines 10828 10828
Branches 895 895
===========================================
- Hits 10096 8489 -1607
- Misses 602 2095 +1493
- Partials 130 244 +114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For some reason when I tried this, it didn't start flowmachine. Probably a weird glitch on my end - I'll try again. |
Tried this but it still doesn't work for me. I can run the script but once it's up I still get |
@flowstef Note that to test this you'll need to export |
I tried both with the GIT_REVISION var and running it just by checking out the correct branch and using the local |
Ah, my bad - the environment variables provided are being overridden by the downloaded |
ae3b38a
to
70007c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still failing to start flowmachine, but I can't see how that could be related to these changes. I'm getting errors when I run the script:
Starting containers (this may take a few minutes)
Pulling worked_examples ... done
Pulling flowauth ... done
Pulling flowapi ... done
Pulling flowdb ... done
Pulling flowmachine_query_locker ... done
Pulling flowmachine ... done
Creating network "flowkit_qs_default" with the default driver
Creating network "flowkit_qs_flowetl" with the default driver
Creating network "flowkit_qs_zero" with the default driver
Creating network "flowkit_qs_api" with the default driver
Creating network "flowkit_qs_db" with the default driver
Creating network "flowkit_qs_redis" with the default driver
Creating worked_examples ...
Creating flowdb ...
Creating flowapi ...
Creating flowauth ...
Creating flowmachine_query_locker ...
ERROR: for flowmachine_query_locker UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowdb UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowauth UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowapi UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for worked_examples UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowmachine_query_locker UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowdb UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowauth UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for flowapi UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: for worked_examples UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
ERROR: An HTTP request took too long to complete. Retry with --verbose to obtain debug information.
If you encounter this issue regularly because of slow network conditions, consider setting COMPOSE_HTTP_TIMEOUT to a higher value (current value: 60).
After waiting a while everything starts up OK despite the error messages, except that there's no sign of flowmachine.
But flowdb does have data for the specified country. I don't think the disaster region pcod is working, though - with COUNTRY=GBR
and DISASTER_REGION_PCOD=GBR.1.36_1
, looking at modal locations in the 2 weeks starting 2016-02-11 (the default disaster start date), there are still a normal number of residents in Greater London.
Ah, I just re-read the docs change and realised I should be using |
c488dbb
to
b7247d0
Compare
b7247d0
to
2ad3306
Compare
2ad3306
to
a7b34e5
Compare
a7b34e5
to
8b8267e
Compare
8b8267e
to
d305394
Compare
Closes #5796
I have:
Description
Allows setting the country used for synthetic data with quickstart script.