-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerized worked examples #694
Conversation
To try this out prior to merging to master, you can run: CI=true CIRCLE_SHA1=21fc0dbb7f3d79391bf736e30e38ea5c80710a25 bash <(curl -s https://raw.githubusercontent.com/Flowminder/FlowKit/21fc0dbb7f3d79391bf736e30e38ea5c80710a25/quick_start.sh) examples (Once the currently running CI process finished) |
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 93.65% 88.55% -5.11%
==========================================
Files 127 13 -114
Lines 6384 1083 -5301
Branches 677 0 -677
==========================================
- Hits 5979 959 -5020
+ Misses 283 124 -159
+ Partials 122 0 -122
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 129 129
Lines 6412 6412
Branches 678 678
=======================================
Hits 6007 6007
Misses 283 283
Partials 122 122
Continue to review full report at Codecov.
|
A few issues I've come across so far:
|
Makefile
Outdated
@@ -108,6 +108,16 @@ flowauth-build: | |||
docker-compose -f $(DOCKER_COMPOSE_FILE) -f $(DOCKER_COMPOSE_FILE_BUILD) build flowauth | |||
|
|||
|
|||
worked-examples-up: worked-examples-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked_examples-up
instead of worked-examples-up
would be more consistent with the names of the other targets.
docs/source/install.md
Outdated
for the examples with a small dataset, or | ||
|
||
```bash | ||
bash <(curl -s https://raw.githubusercontent.com/Flowminder/FlowKit/master/quick_start.sh) examples larger_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful to also give instructions here for stopping the system cleanly (presumably bash ... stop
is sufficient).
Ok, let’s -
I had it as synth originally, but it takes soooo long to spin up on ci that I swapped it to the testdata. |
d97b49f
to
3418e72
Compare
…ith larger data, rename synth flag larger_data
…n quickstart, fix all down check on CI
e3fa017
to
21fc0db
Compare
Co-Authored-By: greenape <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, very nice work! 👏
Great to have the worked examples readily available. 🎉
When I tried to execute them inside the docker containers there were few errors, but they have nothing to do with this PR (basically we haven't upgraded them to more recent versions of flowclient, and a couple of things could be done more conveniently). So let's address this separately (and it may already be part of what @jch1g10 is working on).
Co-Authored-By: greenape <[email protected]>
Closes #614 closes #688
I have:
Description
Overall intent: make the worked examples super easy to run.